-
Notifications
You must be signed in to change notification settings - Fork 381
Update 1042-S and 1099-NEC templates #1595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| "topmostSubform[0].Copy#{tax_form_copy}[0].LeftColumn[0].f1_28[0]" => normalized_tax_field(billing_entity_name), | ||
| "topmostSubform[0].Copy#{tax_form_copy}[0].LeftColumn[0].f1_29[0]" => country_code, | ||
| "topmostSubform[0].Copy#{tax_form_copy}[0].LeftColumn[0].f1_30[0]" => normalized_street_address, | ||
| "topmostSubform[0].Copy#{tax_form_copy}[0].RightColumn[0].f1_31[0]" => normalized_tax_field(full_city_address), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the new template LeftCol changed to LeftColumn and RightCol changed to RightColumn. And f1_31 moved from LeftColumn to RightColumn
|
|
||
| class TaxDocuments::Form1099necSerializer < TaxDocuments::BaseSerializer | ||
| TAX_FORM_COPIES = %w[A 1 B 2 C].freeze | ||
| TAX_FORM_COPIES = %w[A 1 B 2].freeze |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy C no longer exist
| "topmostSubform[0].Copy#{tax_form_copy}[0].LeftCol[0].f#{page_number}_7[0]" => normalized_tax_field(full_city_address), | ||
| # Nonemployee compensation | ||
| "topmostSubform[0].Copy#{tax_form_copy}[0].RightColumn[0].f#{page_number}_9[0]" => compensation_amount_for_tax_year(tax_year), | ||
| "topmostSubform[0].Copy#{tax_form_copy}[0].RightCol[0].f#{page_number}_9[0]" => compensation_amount_for_tax_year(tax_year), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LeftColumn changed to LeftCol and RightColumn changed to RightCol
|
|
||
| private | ||
| def header_for(tax_form_copy) | ||
| case tax_form_copy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
header_for method no longer needed, all copies now use PgHeader
|
|
||
| result = { | ||
| "topmostSubform[0].Copy#{tax_form_copy}[0].Copy#{tax_form_copy}Header[0].CalendarYear[0].f#{page_number}_1[0]" => formatted_tax_year, | ||
| "topmostSubform[0].Copy#{tax_form_copy}[0].CopyHeader[0].CalendarYear[0].f#{page_number}_1[0]" => tax_year.to_s, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| { | ||
| "topmostSubform[0].Copy#{tax_form_copy}[0].#{header_for(tax_form_copy)}Header[0].CalendarYear[0].f#{page_number}_1[0]" => tax_year.to_s.last(2), | ||
| "topmostSubform[0].Copy#{tax_form_copy}[0].PgHeader[0].CalendarYear[0].f#{page_number}_1[0]" => tax_year.to_s, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
@ershad _a
|






Issue: https://chat.google.com/room/AAQAWojMDVI/cvwCBw-61Yo/030bMO0dPdk?cls=10
Description
Update tax form PDF templates to 2025 versions and update serializer code to match the new field naming conventions
Problem
The 1042-S and 1099-NEC PDF templates were outdated (2024 versions). The IRS releases new versions of these forms each tax year with updated templates
We don't show "For calendar year" for 1099-DIV, and wrong year format on 1099-NEC
Solution
Updated the 1042-S and 1099-NEC PDF templates to their 2025 versions and modified the corresponding serializers to match the new field naming conventions. 1099-DIV not updated since the current template already the latest template, see https://www.irs.gov/forms-pubs/about-form-1099-div
Updated the "For calendar year" serializer for 1099-DIV and 1099-DEV
Before/After
Before
After
1042-S
1099-NEC
1099-DIV
AI Disclosure
Claude Opus 4.5 for code generation, all code self reviewed.